Remove deprecated from description of kyuubi.frontend.bind.host #4005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
3 tasks
yaooqinn
reviewed
Dec 19, 2022
|
|
||
| val FRONTEND_BIND_HOST: OptionalConfigEntry[String] = buildConf("kyuubi.frontend.bind.host") | ||
| .doc("(deprecated) Hostname or IP of the machine on which to run the thrift frontend service " + | ||
| .doc("Hostname or IP of the machine on which to run the thrift frontend service " + |
Codecov Report
@@ Coverage Diff @@
## master #4005 +/- ##
============================================
- Coverage 52.11% 52.08% -0.03%
Complexity 13 13
============================================
Files 541 541
Lines 29468 29468
Branches 3938 3938
============================================
- Hits 15357 15349 -8
- Misses 12709 12715 +6
- Partials 1402 1404 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yaooqinn
approved these changes
Dec 19, 2022
pan3793
added a commit
that referenced
this pull request
Dec 19, 2022
…bind.host ### _Why are the changes needed?_ Unlike `kyuubi.frontend.bind.port`, which is deprecated and replaced by `kyuubi.frontend.thrift.binary.bind.port`, `kyuubi.frontend.bind.host` is still encouraged to use, and it can be overwritten by `kyuubi.frontend.<protocol>.bind.host`, e.g. `kyuubi.frontend.thrift.binary.bind.host`, `kyuubi.frontend.thrift.http.bind.host`, `kyuubi.frontend.rest.bind.host`, `kyuubi.frontend.mysql.bind.host` ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4005 from pan3793/doc. Closes #4005 9c3b127 [Cheng Pan] comments 0ef140e [Cheng Pan] Remove deprecated from description of kyuubi.frontend.bind.host Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 6e5803c) Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Unlike
kyuubi.frontend.bind.port, which is deprecated and replaced bykyuubi.frontend.thrift.binary.bind.port,kyuubi.frontend.bind.hostis still encouraged to use, and it can be overwritten bykyuubi.frontend.<protocol>.bind.host, e.g.kyuubi.frontend.thrift.binary.bind.host,kyuubi.frontend.thrift.http.bind.host,kyuubi.frontend.rest.bind.host,kyuubi.frontend.mysql.bind.hostHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request