[DOCS][HELM] Refine helm chart docs #4314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnskr
force-pushed
the
update_helm_chart_doc_page
branch
from
4edb3f7 to
d7c18fd
Compare
pan3793
approved these changes
Feb 12, 2023
pan3793
pushed a commit
that referenced
this pull request
Feb 12, 2023
### _Why are the changes needed?_ The changes are needed to make doc page clearer and a bit nicer, and reflect latest changes in the chart. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request This patch had conflicts when merged, resolved by Committer: Cheng Pan <chengpan@apache.org> Closes #4314 from dnskr/update_helm_chart_doc_page. Closes #4314 d7c18fd [dnskr] [DOCS][HELM] Refine helm chart docs Authored-by: dnskr <dnskrv88@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 68b70ca) Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
|
Thanks, merged to master |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The changes are needed to make doc page clearer and a bit nicer, and reflect latest changes in the chart.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request