[ARROW] Assign a new execution id for arrow-based result #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfmcgrady
commented
Feb 21, 2023
...ls/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/RowSet.scala
Show resolved
Hide resolved
5 tasks
cfmcgrady
commented
Feb 22, 2023
| @@ -433,13 +433,13 @@ trait SparkQueryTests extends SparkDataTypeTests with HiveJDBCTestHelper { | |||
| expectedFormat = "thrift") | |||
| checkStatusAndResultSetFormatHint( | |||
| sql = "set kyuubi.operation.result.format=arrow", | |||
| expectedFormat = "arrow") | |||
| expectedFormat = "thrift") | |||
There was a problem hiding this comment.
This PR changes the behavior, after this PR, the set format operation will take effect after the current operation set kyuubi.operation.result.format=thrift/arrow;
pan3793
reviewed
Feb 22, 2023
...rk-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Feb 22, 2023
...rk-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Feb 22, 2023
...rk-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Feb 22, 2023
.../src/test/scala/org/apache/kyuubi/engine/spark/operation/SparkArrowbasedOperationSuite.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Feb 22, 2023
|
Thanks, merged to master/1.7 |
pan3793
pushed a commit
that referenced
this pull request
Feb 22, 2023
### _Why are the changes needed?_ assign a new execution id for arrow-based result, so that we can track the arrow-based queries on the UI tab. ```sql set kyuubi.operation.result.format=arrow; select 1; ``` Before this PR:   After this PR:   ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4392 from cfmcgrady/arrow-execution-id-2. Closes #4392 481118a [Fu Chen] enable ut c90674e [Fu Chen] address comment 6cc7af4 [Fu Chen] address comment 3f8a3ab [Fu Chen] fix ut 223a246 [Fu Chen] add KyuubiSparkContextHelper bb7b28f [Fu Chen] fix style 879a150 [Fu Chen] unnecessary changes a2b04f8 [Fu Chen] fix Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit f0acff3) Signed-off-by: Cheng Pan <chengpan@apache.org>
3 tasks
pan3793
pushed a commit
that referenced
this pull request
Feb 23, 2023
…L UI ### _Why are the changes needed?_ Currently, the SQL metrics are missing from the SQL UI tab, this is because we mistakenly bound QueryExecution in [PR-4392](#4392), before this PR, it was `resultDF.queryExecution` that was bound to `SQLExecution.withNewExecutionId()`, But the executed Dataset is `resultDF.select(cols: _*)`, this PR passed the correct QueryExecution `resultDF.select(cols: _*).queryExecution` to solve this problem. ```sql set kyuubi.operation.result.format=arrow; select 1; ``` Before this PR:  After this PR:  ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4402 from cfmcgrady/arrow-metrics. Closes #4402 e0cde3b [Fu Chen] fix style b35cbfd [Fu Chen] fix 542414e [Fu Chen] make arrow-based query metrics trackable in SQL UI Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793
pushed a commit
that referenced
this pull request
Feb 23, 2023
…L UI ### _Why are the changes needed?_ Currently, the SQL metrics are missing from the SQL UI tab, this is because we mistakenly bound QueryExecution in [PR-4392](#4392), before this PR, it was `resultDF.queryExecution` that was bound to `SQLExecution.withNewExecutionId()`, But the executed Dataset is `resultDF.select(cols: _*)`, this PR passed the correct QueryExecution `resultDF.select(cols: _*).queryExecution` to solve this problem. ```sql set kyuubi.operation.result.format=arrow; select 1; ``` Before this PR:  After this PR:  ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4402 from cfmcgrady/arrow-metrics. Closes #4402 e0cde3b [Fu Chen] fix style b35cbfd [Fu Chen] fix 542414e [Fu Chen] make arrow-based query metrics trackable in SQL UI Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 3016f43) Signed-off-by: Cheng Pan <chengpan@apache.org>
turboFei
pushed a commit
that referenced
this pull request
Feb 23, 2023
…L UI ### _Why are the changes needed?_ Currently, the SQL metrics are missing from the SQL UI tab, this is because we mistakenly bound QueryExecution in [PR-4392](#4392), before this PR, it was `resultDF.queryExecution` that was bound to `SQLExecution.withNewExecutionId()`, But the executed Dataset is `resultDF.select(cols: _*)`, this PR passed the correct QueryExecution `resultDF.select(cols: _*).queryExecution` to solve this problem. ```sql set kyuubi.operation.result.format=arrow; select 1; ``` Before this PR:  After this PR:  ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4402 from cfmcgrady/arrow-metrics. Closes #4402 e0cde3b [Fu Chen] fix style b35cbfd [Fu Chen] fix 542414e [Fu Chen] make arrow-based query metrics trackable in SQL UI Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 3016f43) Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
assign a new execution id for arrow-based result, so that we can track the arrow-based queries on the UI tab.
Before this PR:
After this PR:
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request