Add operation lock instead of locking state Enumeration #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
yaooqinn
reviewed
Apr 20, 2023
kyuubi-common/src/main/scala/org/apache/kyuubi/operation/AbstractOperation.scala
Outdated
Show resolved
Hide resolved
turboFei
commented
Apr 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #4739 +/- ##
============================================
- Coverage 58.03% 58.02% -0.01%
Complexity 13 13
============================================
Files 580 581 +1
Lines 32270 32320 +50
Branches 4307 4310 +3
============================================
+ Hits 18728 18754 +26
- Misses 11739 11761 +22
- Partials 1803 1805 +2
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
|
thanks, merged to master there is conflicts with branch-1.7, |
pan3793
pushed a commit
that referenced
this pull request
Apr 21, 2023
We meet an issue that cause all the operation stuck when closing operation. Because now all the operations try to lock a Scala Enumeration val. And if one of them stuck, all the others will be keep stuck. In this pr, I add a lock for each operation. - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4739 from turboFei/op_lock. Closes #4739 535400a [fwang12] revert a934389 [fwang12] lockInterruptibly 274abc9 [fwang12] utils ceda731 [fwang12] op lock Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com>
|
Cherry-picked to 1.7 |
beryllw
pushed a commit
to beryllw/incubator-kyuubi
that referenced
this pull request
May 29, 2024
…state Enumeration
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
We meet an issue that cause all the operation stuck when closing operation.
Because now all the operations try to lock a Scala Enumeration val.
And if one of them stuck, all the others will be keep stuck.
In this pr, I add a lock for each operation.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request