-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6294] Simplify Netty and gRPC dependency management #6310
Conversation
Hello @pan3793, Mr.Pan, I have attempted to remove the content of |
<artifactId>netty-all</artifactId> | ||
<version>${netty.version}</version> | ||
<exclusions> | ||
<exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, my vision is to extend this exclusion list instead of declaring everything explicitly. for example, netty-codec-socks
does not used by Kyuubi, and we should add it into exclusion list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emmm, I know, I will try it again. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed I was wrong on this assumption, apologize for this comment.
The netty jars come from grpc-netty
, arrow-memory-netty
, use netty-bom
and grpc-bom
to simplify the dependency management.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6310 +/- ##
============================================
- Coverage 58.47% 58.45% -0.02%
Complexity 24 24
============================================
Files 652 653 +1
Lines 39645 39775 +130
Branches 5454 5473 +19
============================================
+ Hits 23181 23252 +71
- Misses 13984 14034 +50
- Partials 2480 2489 +9 ☔ View full report in Codecov by Sentry. |
Hello, Mr.Pan @pan3793 , I try it again, and exclusion everyone, I removed all dependencies and tried to start it without any issues.
|
seems a little bit more complex than I originally thought, I will take a look. |
# 🔍 Description ## Issue References 🔗 This pull request fixes #6294 ## Describe Your Solution 🔧 The netty jars come from `grpc-netty`, `arrow-memory-netty`, use `netty-bom` and `grpc-bom` to simplify the dependency management. Run `./build/dependency.sh --replace` ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6310 from PorterZhang2021/issue-6294. Closes #6294 3270301 [Cheng Pan] simplify netty dependency management cdb435d [PorterZhang2021] [# 6294] Prune unused Netty libraries e0676ed [PorterZhang2021] Finished Prune unused Netty libraries [#6294] Lead-authored-by: PorterZhang2021 <PorterZhang2021@outlook.com> Co-authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 962de72) Signed-off-by: Cheng Pan <chengpan@apache.org>
Merged to master/1.9.1 |
🔍 Description
Issue References 🔗
This pull request fixes #6294
Describe Your Solution 🔧
The netty jars come from
grpc-netty
,arrow-memory-netty
, usenetty-bom
andgrpc-bom
to simplify the dependency management.Run
./build/dependency.sh --replace
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.