[KYUUBI #6299] Support disabling Web UI #6311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
pan3793
reviewed
Apr 16, 2024
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Apr 16, 2024
| @@ -116,6 +116,13 @@ class KyuubiRestFrontendService(override val serverable: Serverable) | |||
| } | |||
|
|
|||
| private def installWebUI(): Unit = { | |||
| if (!conf.get(FRONTEND_REST_ENABLE_WEBUI)) { | |||
There was a problem hiding this comment.
prefer to judge on the caller's side to make this function clear. BTW, what will happen if we don't inject the enable.html page?
There was a problem hiding this comment.
If we don't inject the enable.html, we just get a 404 page.
cxzl25
changed the title
pan3793
reviewed
Apr 16, 2024
pan3793
approved these changes
Apr 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6311 +/- ##
============================================
- Coverage 58.51% 58.43% -0.08%
Complexity 24 24
============================================
Files 652 653 +1
Lines 39649 39775 +126
Branches 5454 5473 +19
============================================
+ Hits 23199 23243 +44
- Misses 13970 14039 +69
- Partials 2480 2493 +13 ☔ View full report in Codecov by Sentry. |
|
Thanks, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #6299
Describe Your Solution 🔧
when disabling web ui, return 404 page
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.