-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6281][PY] Initialize github action for python unit testing #6343
Conversation
f235c71
to
2172f69
Compare
@pan3793 not sure this is which type of change, new feature or bug fix? |
Are there any other options that we can consider? |
thanks for informing, where can I see that message in full version? @yaooqinn |
https://github.com/apache/kyuubi/actions/runs/8868934136 You can navi to this page via |
ah thanks a lot, that's why it doesn't appear below |
Yeah, We can refer to other Apache repos for available actions |
docker compose is fine too. and trino provides some pre-built images for Hadoop/Hive/Spark https://github.com/trinodb/docker-images |
@sudohainguyen hadoop-testing is for local dev. for CI case, docker compose / single docker image approach is preferred. so I suggest u refer to Trino's approach. Apache has strict rules for GitHub Actions plugins, you may need to install docker compose manually or leverage testcontainers(we already use the Java/Scala one) |
080c29d
to
46c3ce0
Compare
just switched action provider to failed somewhere, testing on my personal repo |
Signed-off-by: Harry <quanghai.ng1512@gmail.com>
Signed-off-by: Harry <quanghai.ng1512@gmail.com>
Signed-off-by: Harry <quanghai.ng1512@gmail.com>
Signed-off-by: Harry <quanghai.ng1512@gmail.com>
d12a723
to
248e7e4
Compare
ok works now @pan3793
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6343 +/- ##
============================================
- Coverage 58.47% 58.44% -0.04%
Complexity 24 24
============================================
Files 653 653
Lines 39880 39880
Branches 5481 5481
============================================
- Hits 23320 23306 -14
- Misses 14071 14075 +4
- Partials 2489 2499 +10 ☔ View full report in Codecov by Sentry. |
@pan3793 could we process this MR please 👀 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary disabled hive related test due to test cases are not valid
Can you elaborate more on it?
|
||
services: | ||
namenode: | ||
image: bde2020/hadoop-namenode:2.0.0-hadoop2.7.4-java8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hadoop 2.0.0 is extremely old, why choose this image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was using existing images on the internet to save overhead preparation time 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think in the future this should be kyuubi image instead?
@sudohainguyen sorry for being late, just got back to the office today |
Co-authored-by: Cheng Pan <pan3793@gmail.com>
yep, I've ran all test cases and can see the result here |
but I found 5 |
yes this relates to hive test cases we need to resolve in the upcoming PR 😄, annotation parts are to skip those test cases trigger restarted hive server, we cannot replicate those ones |
Thanks, merged to master |
# 🔍 Description ## Issue References 🔗 This pull request fixes #6281 Following up to #6343 , this PR adds `pytest-xdist` plugin to speed up python client unit testing ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ Running tests usually takes ~10 mins #### Behavior With This Pull Request 🎉 Running tests can take up to 5 mins #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6369 from sudohainguyen/ci/speed-up-test. Closes #6281 f0ce557 [Harry] [KYUUBI #6281][PY] Speed up testing with xdist plugin Authored-by: Harry <quanghai.ng1512@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
# 🔍 Description ## Issue References 🔗 This pull request enables running hive test cases in python client, however there's one trivial case not covered yet and two others require a proper container setup ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ Hive test disabled in #6343 #### Behavior With This Pull Request 🎉 Can cover hive test cases #### Related Unit Tests No --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6381 from sudohainguyen/ci/hive. Closes #6281 a861382 [Harry] [KYUUBI #6281][PY] Enable hive test in python client Authored-by: Harry <quanghai.ng1512@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
🔍 Description
Issue References 🔗
This pull request fixes #6281
Describe Your Solution 🔧
The change initialize a CI job to run unit testing on python client, including:
presto
andtrino
pytest-xdist
pluginTypes of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Not able to ran unit test in local and on CI
Behavior With This Pull Request 🎉
Able to run and partially cover a couple of test cases
Related Unit Tests
No
Additional notes
Next action is about fixing failing test cases or considering skipping some of them if necessary
Checklist 📝
Be nice. Be informative.