[KYUUBI #6720] K8s pod OOM Killed should be identified as Application failed state #6721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation failed state
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6721 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 684 684
Lines 42281 42282 +1
Branches 5766 5767 +1
======================================
- Misses 42281 42282 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pan3793
approved these changes
Oct 2, 2024
pan3793
changed the title
pan3793
pushed a commit
that referenced
this pull request
Oct 2, 2024
… failed state # 🔍 Description ## Issue References 🔗 This pull request fixes #6720 ## Describe Your Solution 🔧 If pod goes into OOMKilled state, application should be marked as KILLED, which is eventually identified as isFailed ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Tested locally, was able to launch new session <img width="922" alt="kyuubi_new_session" src="https://github.com/user-attachments/assets/b003c86f-484d-40c5-b173-847374a45b1d"> --- **Be nice. Be informative.** Closes #6721 from Madhukar525722/OOM. Closes #6720 cd0bdf6 [madlnu] [KYUUBI #6720] K8s pod OOM Killed should be identified as Application failed state Authored-by: madlnu <madlnu@visa.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 2d64255) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Thanks, merged to master/1.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #6720
Describe Your Solution 🔧
If pod goes into OOMKilled state, application should be marked as KILLED, which is eventually identified as isFailed
Types of changes 🔖
Test Plan 🧪
Tested locally, was able to launch new session
Be nice. Be informative.