Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AWS region me-central-1
Description
We need support for opt in AWS region
me-central-1
.Resources:
endpoint
: https://docs.aws.amazon.com/general/latest/gr/ec2-service.htmlcountry
andsignature_version
: https://docs.aws.amazon.com/general/latest/gr/s3.htmlStatus
We tried to follow the documentation (see [1]) to update theses files:
contrib/scrape-ec2-prices.py
contrib/scrape-ec2-sizes.py
Sadly when running
tox -e scrape-ec2-sizes,scrape-ec2-prices
,scrape-ec2-sizes
failed:Afterwards we retried with trunk and its also failing:
Also the mentioned example (see [2]) in the documentation is outdated. The list
EC2_REGIONS
does not exist anymore incontrib/scrape-ec2-prices.py
.The change we did seems to be sufficient to delete a VM, are there other tests to run?
[1] https://libcloud.readthedocs.io/en/latest/development.html#updating-ec2-sizing-and-supported-regions-data
[2] 762f0e5
Checklist (tick everything that applies)