Skip to content

Conversation

@edwgiz
Copy link
Contributor

@edwgiz edwgiz commented Jan 11, 2023

Hello @ppkarwasz

Basically I moved the changes by the past PR, the maven build is succussfull with followind command

mvn --projects log4j-transform-maven-shade-plugin-extensions clean verify

the open question for me is how to gracefully adapt documentation which is in log4j-transform-maven-shade-plugin-extensions/src/site/markdown/index.md

Looking for your feedback

Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edwgiz,

Thank you for adapting PR logging-log4j-tools#2 so fast.

Although I didn't set up Github Actions on this repo yet, I run the tests locally and it looks good to me.

@vy: how should we organize the documentation?

@jvz: do we need a contributor agreement?

@vy
Copy link
Member

vy commented Jan 11, 2023

For the documentation, I suggest simply using a README.adoc at the module folder and linking to that in the root README.adoc – I have done this in log4j-tools. In the Log4j manual, we can simply link to the project repo, i.e., https://github.com/apache/logging-log4j-transform, which greets users with the root README.adoc. This can be a good temporary workaround until I complete my work on setting up Antora.

@edwgiz has already signed the ICLA – search for "Eduard Gizatullin" in private@logging.apache.org archives.

@ppkarwasz ppkarwasz merged commit 6b417c0 into apache:main Jan 11, 2023
@ppkarwasz
Copy link
Contributor

@edwgiz,

Thank again for the contribution. We plan to release the artifacts in this repo shortly after 2.20.0.

@jvz
Copy link
Member

jvz commented Jan 11, 2023

And ICLAs are primarily required for committers anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants