Fix locale-dependent `toLowerCase()/toUpperCase()` calls

[ppkarwasz]

Log4j2 has a couple of remaining call sites of String#toLowerCase and String#toUpperCase, which are locale-dependent. These calls should be replaced with Strings#toRootLowerCase and Strings#toRootUpperCase.

Such a call is present for example in PluginManager, which causes IfLastModified to be transformed to ıflastmodified (with a dotless i), if the locale is Turkish (cf. this SO question).

[ppkarwasz]

I think this can be a good first issue: there are already helper methods Strings#toRootLowerCase and Strings#toRootUpperCase.

[akashshirale14]

Can you assign this issue to me?

[ppkarwasz]

@akashshirale14,

Done. I also updated the issue description: we already have methods Strings#toRootLowerCase/toRootUpperCase that sound less English-centric and do the same thing.

[awadammar]

Hello, @akashshirale14
Are you still working on this issue? If you're not, I'm interested to work on it.

[akashshirale14]

Hi Ammar, Yes, you can take it. Regards, Akash Shirale

…

On Tue, May 16, 2023 at 2:08 AM Ammar Yasser ***@***.***> wrote: Hello, @akashshirale14 <https://github.com/akashshirale14> Are you still working on this issue?, I'm interested to work on it. — Reply to this email directly, view it on GitHub <#1281 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALB5P4ALUFBNWHEOPGOXHGDXGKH4FANCNFSM6AAAAAAVC3LA6U> . You are receiving this because you were mentioned.Message ID: ***@***.***>