Skip to content

Build fails with RAT errors for files in log4j-osgi-test/felix-cache/bundle0/ #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garydgregory opened this issue Oct 2, 2024 · 2 comments
Labels

Comments

@garydgregory
Copy link
Member

garydgregory commented Oct 2, 2024

Description

Tyje build (mvn clean verify) fails with RAT error for files in log4j-osgi-test/felix-cache/bundle0/

When I'm lucky ;-) the build makes it all the way to the log4j-osgi-test module but always fails with RAT errors:

type log4j-osgi-test\target\rat.txt

*****************************************************
Summary
-------
Generated at: 2024-10-01T18:51:34-04:00

Notes: 0
Binaries: 0
Archives: 0
Standards: 13

Apache Licensed: 11
Generated Documents: 0

JavaDocs are generated, thus a license header is optional.
Generated files do not require license headers.

2 Unknown Licenses

*****************************************************

Files with unapproved licenses:

  C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/felix-cache/bundle0/bundle.id
  C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/felix-cache/bundle0/last.java.version

*****************************************************

*****************************************************
  Files with Apache License headers will be marked AL
  Binary files (which do not require any license headers) will be marked B
  Compressed archives will be marked A
  Notices, licenses etc. will be marked N
  AL    C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/.flattened-pom.xml
 !????? C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/felix-cache/bundle0/bundle.id
 !????? C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/felix-cache/bundle0/last.java.version
  AL    C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/pom.xml
  AL    C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/src/test/java/org/apache/logging/log4j/osgi/tests/AbstractLoadBundleTest.java
  AL    C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/src/test/java/org/apache/logging/log4j/osgi/tests/CoreOsgiTest.java
  AL    C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/src/test/java/org/apache/logging/log4j/osgi/tests/CustomConfiguration.java
  AL    C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/src/test/java/org/apache/logging/log4j/osgi/tests/CustomConfigurationFactory.java
  AL    C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/src/test/java/org/apache/logging/log4j/osgi/tests/EquinoxLoadApiBundleTest.java
  AL    C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/src/test/java/org/apache/logging/log4j/osgi/tests/FelixLoadApiBundleTest.java
  AL    C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/src/test/java/org/apache/logging/log4j/osgi/tests/JULProviderTest.java
  AL    C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/src/test/java/org/apache/logging/log4j/osgi/tests/OsgiRule.java
  AL    C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/src/test/java/org/apache/logging/log4j/osgi/tests/SLF4JProviderTest.java

*****************************************************

 Printing headers for text files without a valid license header...

=====================================================
== File: C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/felix-cache/bundle0/bundle.id
=====================================================
3

=====================================================
== File: C:/Users/ggregory/git/a/logging-log4j2/log4j-osgi-test/felix-cache/bundle0/last.java.version
=====================================================
11

Configuration

Version:

commit ad3c03d231913bfc9d613de91408c61649cc6d60 (HEAD -> 2.x, origin/2.x)
Author: Volkan Yazıcı <volkan@yazi.ci>
Date:   Tue Oct 1 21:09:31 2024 +0200

    Fix Awaitility usage in `SocketAppenderReconnectTest` (#3004)

Operating system:

Microsoft Windows [Version 10.0.19045.4780]

JDK:

openjdk version "17.0.12" 2024-07-16
OpenJDK Runtime Environment Temurin-17.0.12+7 (build 17.0.12+7)
OpenJDK 64-Bit Server VM Temurin-17.0.12+7 (build 17.0.12+7, mixed mode, sharing)
Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: C:\java\apache-maven-3.9.9
Java version: 17.0.12, vendor: Eclipse Adoptium, runtime: C:\Program Files\Eclipse Adoptium\jdk-17.0.12.7-hotspot
Default locale: en_US, platform encoding: UTF-8
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Logs

Captured log (my console is not set up to capture more): https://gist.github.com/garydgregory/a83cd7f046e24febf9be4d43170ceb91

The above is what I copied from the console but is just a part of the log and it looks like I did not capture the end of it but you can still see the contents of the RAT file above.

Reproduction

Run

cls && git log -1 && mvn clean verify
@vy
Copy link
Member

vy commented Oct 2, 2024

@garydgregory, it is a local leftover from an earlier version, you just need to remove the log4j-osgi-test/felix-cache folder.

@vy vy closed this as completed Oct 2, 2024
@vy vy added the invalid label Oct 2, 2024
@garydgregory
Copy link
Member Author

Ah, OK, ty.

dongjoon-hyun pushed a commit to apache/spark that referenced this issue Nov 24, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade log4j2 from `2.24.1` to `2.24.2`.

### Why are the changes needed?
- The full release notes:
https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.24.2

- This release fixes a critical bug in Log4j API initialization code, which can cause LogManager.getLogger() to return null under certain conditions. See apache/logging-log4j2#3143 for details.
  Fix key removal issues in Thread Context (apache/logging-log4j2#3048)
  Use hard references to Loggers in LoggerRegistry. (apache/logging-log4j2#3143)
  Fix ArrayIndexOutOfBoundsException in JSON Template Layout truncated exception resolver (apache/logging-log4j2#3216)

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #48945 from panbingkun/SPARK-50400.

Authored-by: panbingkun <panbingkun@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants