Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2.x/mongodb next gg #2486

Merged
merged 9 commits into from
Apr 19, 2024

Conversation

garydgregory
Copy link
Member

@garydgregory garydgregory commented Apr 18, 2024

Mongo DB PR with 3 commits

  • Add a new log4j-mongodb module to track the current MongoDB Driver, version 5
  • Deprecate log4j-mongodb4 in favor of log4j-mongodb
  • Remove log4j-mongodb3

(it's fine w me to squash on merge)

version 5)

- Work around `PluginProcessor` restrictions.
- The `PluginProcessor` assumes that the factory method of a
`@Plugin`-annotated class returns an instance of the class itself.
- We workaround the problem adding an `implements NoSqlProvider` clause
to
the `MongoDbProvider` class.
Note: log4j-mongodb4 is deprecated for removal
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garydgregory garydgregory merged commit 72205bf into apache:2.x Apr 19, 2024
9 checks passed
@garydgregory garydgregory deleted the feature/2.x/mongodb-next-gg branch April 19, 2024 21:49
@ppkarwasz ppkarwasz added this to the 2.24.0 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants