Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Flume Appender to logging-log4j-flume repo #2902

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

ppkarwasz
Copy link
Contributor

The code of the Flume Appender has been moved to a new logging-log4j-flume.

This PR remove the log4j-flume-ng module from the repository and cleans up the dependency management section.

@ppkarwasz ppkarwasz added this to the 2.24.0 milestone Aug 30, 2024
Copy link
Member

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume you did not update src/site due to the missing logging-log4j-flume website, right?

@ppkarwasz
Copy link
Contributor Author

I presume you did not update src/site due to the missing logging-log4j-flume website, right?

I think that the Flume Appender should be documented in the main site.
We can create a stub /log4j/flume/2.x site later that only refers the user to the main site.

@vy
Copy link
Member

vy commented Aug 30, 2024

I presume you did not update src/site due to the missing logging-log4j-flume website, right?

I think that the Flume Appender should be documented in the main site. We can create a stub /log4j/flume/2.x site later that only refers the user to the main site.

I prefer placing the docs next to the sources. This worked nicely for JMX GUI and Jakarta. Why do you think we need to create an exception for Flume?

@ppkarwasz
Copy link
Contributor Author

I prefer placing the docs next to the sources. This worked nicely for JMX GUI and Jakarta. Why do you think we need to create an exception for Flume?

There must be some integration, so that users can find the appender.

Maybe we can move the Flume Appender documentation to its own website and replace the current description in appenders.adoc with a stub. I would prefer to do it, when the /log4j/flume website is ready though. What do you think?

@ppkarwasz ppkarwasz merged commit 39dba0a into 2.x Aug 30, 2024
9 checks passed
@ppkarwasz ppkarwasz deleted the feature/2.x/move-flume branch August 30, 2024 09:01
@vy
Copy link
Member

vy commented Aug 30, 2024

There must be some integration, so that users can find the appender.

Maybe we can move the Flume Appender documentation to its own website and replace the current description in appenders.adoc with a stub. I would prefer to do it, when the /log4j/flume website is ready though. What do you think?

When /log4j/flume is up, we can place pointers to nav.adoc, appenders.adoc, etc. for Flume-related stuff. But I am not keen on sharing Flume-related technical details in /log4j/2.x, IMO, they should be situated in /log4j/flume instead.

ppkarwasz added a commit that referenced this pull request Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants