You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed Milestone 1. Upgrade from JUnit 4 to JUnit 5. This PR migrates the tests located in log4j-osgi-test.
Thank you!
Checklist
Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
We have some questions we would like to ask. We've found that the test suites CoreOsgiTest, JULProviderTest and SLF4JProviderTest are using PaxExam, and the current version does not support JUnit 5. Before attempting an upgrade, we were wondering, does this feature need to be updated? We are missing some context, what is being checked by using this runner? Any help in this regard is greatly appreciated. Thank you!
Before attempting an upgrade, we were wondering, does this feature need to be updated? We are missing some context, what is being checked by using this runner? Any help in this regard is greatly appreciated. Thank you!
Since PAX Exam is basically dormant, it would be better to move those tests to a different framework, but honestly I don't know which. @HannesWell, any suggestions?
Frameworks like Testcontainer for Java or Arquillian are not very OSGi friendly. The "new" osgi-test assumes that the test is already running in an OSGi environment. Maybe we could use something like laeubisoft/osgi-test-framework or the BND Testing Plugin. I will experiment with the latter. We already use BND plugins and they work well. I would like to keep the list of Open Source vendors we rely on minimal.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋
We are from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed Milestone 1. Upgrade from JUnit 4 to JUnit 5. This PR migrates the tests located in
log4j-osgi-test.Thank you!
Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:applyand retry)src/changelog/.2.x.xdirectory