Skip to content

Conversation

jluehe
Copy link
Contributor

@jluehe jluehe commented May 24, 2025

… directly instead of reflectively (#3686)

[A clear and concise description of what the pull request is for along with a reference to the associated issue IDs, if they exist.]

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution — the changes look good to me!

Since this PR doesn’t introduce any new methods, no additional unit tests are needed. However, there are a couple of small tasks to complete before we can proceed with merging:

Let me know if you need any help with these steps!

Copy link

github-actions bot commented May 24, 2025

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

@jluehe
Copy link
Contributor Author

jluehe commented May 25, 2025

However, there are a couple of small tasks to complete before we can proceed with merging: ...

Thank you, @ppkarwasz! I've recreated the PR at #3690 with the missing items. Closing this PR

@jluehe jluehe closed this May 25, 2025
@github-project-automation github-project-automation bot moved this from To triage to Done in Log4j bug tracker May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants