Add new date pattern for DatePatternConverterTestBase and add new test class for LegacyInstantFormatter - tests for #3930 #3931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t class for LegacyInstantFormatter reprodcing bug apache#3667
ppkarwasz
requested changes
Sep 18, 2025
There was a problem hiding this comment.
Hi @tanmaybaid,
Thank you for the PR!
I am not really convinced we want to test the legacy formatter, but we'll certainly include the part for the new formatter.
| assertDatePattern("dd/MM/yyyy HH:mm:ss.SSSSSS", date, "11/03/2011 14:15:16.123000"); | ||
| assertDatePattern("dd/MM/yy HH:mm:ss.SSS", date, "11/03/11 14:15:16.123"); | ||
| assertDatePattern("dd/MM/yy HH:mm:ss.SSSSSS", date, "11/03/11 14:15:16.123000"); | ||
| assertDatePattern("EEE, dd MMM yyyy HH:mm:ss zzz", date, "Fri, 11 Mar 2011 14:15:16 PST"); |
There was a problem hiding this comment.
Thanks for the test case, much appreciated! 💯
| @SetTestProperty(key = "log4j2.instantFormatter", value = "legacy") | ||
| }) | ||
| @UsingTestProperties | ||
| class DatePatternConverterWithLegacyInstantFormatterTest extends DatePatternConverterTestBase { |
There was a problem hiding this comment.
Personally I don't think we want to introduce more tests for the legacy formatter, since it is deprecated and will not change any more. @vy, what do you think?
Generated by gradle/develocity-actions |
@tanmaybaid, we're grateful for your contribution, but I agree with @ppkarwasz. I am closing this PR in favor of #3932. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds tests for bug reported in #3930
Following tests are failing as expected due to #3930:
Checklist
Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.
✅ Required checks
License: I confirm that my changes are submitted under the Apache License, Version 2.0.
Commit signatures: All commits are signed and verifiable. (See GitHub Docs on Commit Signature Verification).
Code formatting: The code is formatted according to the project’s style guide.
How to check and fix formatting
./mvnw spotless:check./mvnw spotless:applySee the build instructions for details.
Build & Test: I verified that the project builds and all unit tests pass.
How to build the project
Run:
./mvnw verifySee the build instructions for details.
🧪 Tests (select one)
📝 Changelog (select one)