Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#189 separate review instructions for log4net #190

Merged
merged 8 commits into from
Sep 27, 2024
Merged

#189 separate review instructions for log4net #190

merged 8 commits into from
Sep 27, 2024

Conversation

FreeAndNil
Copy link
Contributor

@FreeAndNil FreeAndNil added this to the 3.0.2 milestone Sep 26, 2024
@FreeAndNil FreeAndNil requested a review from vy September 26, 2024 19:31
vy
vy approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'm trusting you with ps1 scripts, I haven't reviewed them.
  • Dropped a minor remark about MailTemplate.txt.

doc/MailTemplate.txt Show resolved Hide resolved
@FreeAndNil FreeAndNil merged commit 910e2c3 into master Sep 27, 2024
@FreeAndNil FreeAndNil deleted the Feature/190-separate-review-instructions branch September 27, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluffynuts fluffynuts fluffynuts approved these changes

@vy vy vy approved these changes

@ppkarwasz ppkarwasz Awaiting requested review from ppkarwasz

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@FreeAndNil @vy @fluffynuts