Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use raw strings for config files in unit tests #203

Merged
merged 2 commits into from
Nov 1, 2024
Merged

use raw strings for config files in unit tests #203

merged 2 commits into from
Nov 1, 2024

Conversation

FreeAndNil
Copy link
Contributor

  • use raw strings for config files in unit tests
  • fixed more warnings

@FreeAndNil FreeAndNil added this to the 3.0.3 milestone Oct 31, 2024
fluffynuts
fluffynuts approved these changes Nov 1, 2024
View reviewed changes
src/log4net.Tests/Appender/AdoNetAppenderTest.cs Outdated Show resolved Hide resolved
src/log4net.Tests/Appender/RollingFileAppenderTest.cs Outdated Show resolved Hide resolved
@FreeAndNil
Copy link
Contributor Author

Good points. I will adjust the code.

@FreeAndNil
- normalized indentation for raw strings
8408611 
- removed type prefixes from parameters in RollingFileAppenderTest
@FreeAndNil FreeAndNil merged commit f745a69 into master Nov 1, 2024
@FreeAndNil FreeAndNil deleted the Feature/FixWarningsInTests branch November 1, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluffynuts fluffynuts fluffynuts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@FreeAndNil @fluffynuts