SOLR-15555 #2572
Merged
SOLR-15555 #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new cache mode for CaffeineCache where we can optionally use an async cache instead of the synchronous implementation. This is useful for cases (esp FilterQuery) where many identical requests come in near the same time and they would otherwise race to fill the same cache slot. CaffeineCache computeIfAbsent now accepts an IOFunction instead of the non-throwing java.util.Function interface. This required an update to CaffeineCache 2.9, which updates putIfAbsent with an optimistic get. Also incidentally fixes a rare bug where cache ramBytesUsed would be incorrectly reported under heavy cache contention/eviction loads.
thelabdude
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Ran all the tests under solr/core and all passed. Looks good @madrob
madrob
added a commit
that referenced
this pull request
Sep 14, 2021
Create a new cache mode for CaffeineCache where we can optionally use an async cache instead of the synchronous implementation. This is useful for cases (esp FilterQuery) where many identical requests come in near the same time and they would otherwise race to fill the same cache slot. CaffeineCache computeIfAbsent now accepts an IOFunction instead of the non-throwing java.util.Function interface. This required an update to CaffeineCache 2.9, which updates putIfAbsent with an optimistic get. Also incidentally fixes a rare bug where cache ramBytesUsed would be incorrectly reported under heavy cache contention/eviction loads. Makes Async Caches the default.
magibney
pushed a commit
to fullstorydev/lucene-solr
that referenced
this pull request
Jul 27, 2022
Create a new cache mode for CaffeineCache where we can optionally use an async cache instead of the synchronous implementation. This is useful for cases (esp FilterQuery) where many identical requests come in near the same time and they would otherwise race to fill the same cache slot. CaffeineCache computeIfAbsent now accepts an IOFunction instead of the non-throwing java.util.Function interface. This required an update to CaffeineCache 2.9, which updates putIfAbsent with an optimistic get. Also incidentally fixes a rare bug where cache ramBytesUsed would be incorrectly reported under heavy cache contention/eviction loads. Makes Async Caches the default. (cherry picked from commit ac5df22)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new cache mode for CaffeineCache where we can optionally use an
async cache instead of the synchronous implementation. This is useful
for cases (esp FilterQuery) where many identical requests come in near
the same time and they would otherwise race to fill the same cache slot.
CaffeineCache computeIfAbsent now accepts an IOFunction instead of
the non-throwing java.util.Function interface.
This required an update to CaffeineCache 2.9, which updates putIfAbsent
with an optimistic get.
Also incidentally fixes a rare bug where cache ramBytesUsed would be
incorrectly reported under heavy cache contention/eviction loads.
Based on c942c7242c2fb9f45b21675f5895835412ecaf7a