SOLR-8639 replace static SimpleDateFormat with threadsafe jodatimeDateFormatter #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eFormatter instances from joda-time. The joda-time types are threadsafe which is appropriate for this usecase. Keeping the SDF instances could cause data corruption or incorrect values to be returned from the methods that use them.
dragonsinth
referenced
this pull request
in fullstorydev/lucene-solr
Feb 12, 2016
LUCENE-6740: Reduce warnings emitted by javac #5 git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/branches/branch_5x@1696077 13f79535-47bb-0310-9956-ffa450edef68
mnilsson23
added a commit
to mnilsson23/lucene-solr
that referenced
this pull request
Jul 6, 2016
…list-not-collection LTRScoringAlgorithm's allFeatures is now List instead of Collection
desultir
added a commit
to desultir/lucene-solr
that referenced
this pull request
Sep 6, 2016
pull from upstream again
dsmiley
pushed a commit
to dsmiley/lucene-solr
that referenced
this pull request
Jun 22, 2018
Make downnode faster
munendrasn
added a commit
to munendrasn/lucene-solr
that referenced
this pull request
Jun 3, 2020
|
DIH has been moved out to an external package, please consider submitting your patch to https://github.com/rohitbemax/dataimporthandler - thank you! |
bszabo97
pushed a commit
to bszabo97/lucene-solr
that referenced
this pull request
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue SOLR-8639:
sinceDateParser and afterFmt are declared as static variables of type SimpleDateFormat which is not threadsafe. This may cause data corruption and an incorrect value to be returned by the methods that use them.