Skip to content

Commit

Permalink
[TEST] Disable concurrency in TestTaxonomyFacetAssociations#testFloat…
Browse files Browse the repository at this point in the history
…AssociationRandom

The test relies on ordering which requires sequential execution.
  • Loading branch information
javanna committed Sep 6, 2024
1 parent 0b8ae22 commit 0ec453d
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,9 @@ public void testFloatSumAssociation() throws Exception {
}

public void testFloatAssociationRandom() throws Exception {

IndexSearcher searcher = newSearcher(reader);
// disabling search concurrency because validateFloats relies on ordering which requires
// sequential execution
IndexSearcher searcher = newSearcher(reader, true, true, false);
FacetsCollector fc =
searcher.search(new TermQuery(new Term("match", "yes")), new FacetsCollectorManager());

Expand Down Expand Up @@ -617,7 +618,7 @@ private void validateFloats(
float value = e.getValue();
// We can expect the floats to be exactly equal here since we're ensuring that we sum them
// in the same order when determining expected values and when computing facets. See
// LUCENE-10530:
// LUCENE-10530. This though requires sequential execution.
assertEquals(value, facets.getSpecificValue(dim, e.getKey()).floatValue(), 0f);
aggregatedValue = aggregationFunction.aggregate(aggregatedValue, value);
}
Expand Down

0 comments on commit 0ec453d

Please sign in to comment.