Integrate merge-time index reordering with the intra-merge executor. #13289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Index reordering can benefit greatly from parallelism, so it should try to use the intra-merge executor when possible. Because the API only exposes an `Executor` and not a `ForkJoinPool`, parallelism is a bit less good due to some threads potentially waiting for tasks to finish when they could be doing work stealing instead. We should look into whether we can improve this in the future.
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
|
I improved the PR by taking advantage of TaskExecutor's work stealing logic. I plan on merging soon if there are no objections. |
|
@jpountz I think this is a good idea. One concern is that the CMS may not actually use parallelism on tiny merges. Let me separate out the change in this PR to improve our testing around this: https://github.com/apache/lucene/pull/13475/files |
jpountz
added a commit
that referenced
this pull request
Sep 12, 2024
…13289) Index reordering can benefit greatly from parallelism, so it should try to use the intra-merge executor when possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index reordering can benefit greatly from parallelism, so it should try to use the intra-merge executor when possible. Because the API only exposes an
Executorand not aForkJoinPool, parallelism is a bit less good due to some threads potentially waiting for tasks to finish when they could be doing work stealing instead. We should look into whether we can improve this in the future.