Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hunspell: speed up "compress"; minimize the number of the generated entries; don't even consider "forbidden" entries anymore #13429

Merged
merged 2 commits into from
May 28, 2024

Conversation

donnerpeter
Copy link
Contributor

No description provided.

…ntries; don't even consider "forbidden" entries anymore
@donnerpeter donnerpeter requested a review from dweiss May 27, 2024 17:54
Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I've no idea what improvement I'm looking at here but I trust you know!

@dweiss dweiss added this to the 9.11.0 milestone May 27, 2024
@donnerpeter
Copy link
Contributor Author

I admit I've no idea what improvement I'm looking at here but I trust you know!

I can add some comments with explanations :)

@dweiss
Copy link
Contributor

dweiss commented May 27, 2024

I can add some comments with explanations :)

No need. I glanced through the code and it doesn't seem to be a backdoor. :) You know better what works here anyway.

@uschindler uschindler requested a review from rmuir May 27, 2024 18:07
@uschindler
Copy link
Contributor

@rmuir can you have a look?

@uschindler
Copy link
Contributor

I can add some comments with explanations :)

No need. I glanced through the code and it doesn't seem to be a backdoor. :) You know better what works here anyway.

Hahaha. I know donnerpeter and have seen code by him already. But like the xz/liblzma desaster he could possibly be working for long time on taking over the world! We should check if Gradle code was changed!

Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked again and I think I get the gist. No Gradle executable hooks are included.
LGTM.

@donnerpeter donnerpeter merged commit 54d3ff6 into apache:main May 28, 2024
4 checks passed
@donnerpeter donnerpeter deleted the peter/hunspellMinimalCompress branch May 28, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants