Add bw tests for block-tree with inlined metadata. #13527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backport of apache#13524 found a hole in the testing of `Lucene40BlockTreeTerms` for versions before we moved metadata to its own file. This PR adds explicit bw testing for this version. Adding the correct if/else statements made the code extremely complicated so I opted for restoring the file as it was at the time when we bumped the version. This also fixes the bug that we introduced in apache#13524.
jpountz
commented
Jun 27, 2024
| @@ -196,6 +196,7 @@ public void testUnsupportedOldIndexes() throws Exception { | |||
| ByteArrayOutputStream bos = new ByteArrayOutputStream(1024); | |||
| CheckIndex checker = new CheckIndex(dir); | |||
| checker.setInfoStream(new PrintStream(bos, false, UTF_8)); | |||
| checker.setLevel(CheckIndex.Level.MIN_LEVEL_FOR_INTEGRITY_CHECKS); | |||
There was a problem hiding this comment.
I also added this, as it looks like we decreased coverage for ancient indices when we decreased the default level for CheckIndex. Unfortunately, this would still not have been enough to find this bug as the bw indices are too small to have meaningful data in their terms index that would have trigger the bug.
jpountz
added a commit
that referenced
this pull request
Jun 28, 2024
The backport of #13524 found a hole in the testing of `Lucene40BlockTreeTerms` for versions before we moved metadata to its own file. This PR adds explicit bw testing for this version. Adding the correct if/else statements made the code extremely complicated so I opted for restoring the file as it was at the time when we bumped the version. This also fixes the bug that we introduced in #13524.
linfn
pushed a commit
to linfn/lucene
that referenced
this pull request
Nov 5, 2024
The backport of apache#13524 found a hole in the testing of `Lucene40BlockTreeTerms` for versions before we moved metadata to its own file. This PR adds explicit bw testing for this version. Adding the correct if/else statements made the code extremely complicated so I opted for restoring the file as it was at the time when we bumped the version. This also fixes the bug that we introduced in apache#13524.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backport of #13524 found a hole in the testing of
Lucene40BlockTreeTermsfor versions before we moved metadata to its own file. This PR adds explicit bw testing for this version. Adding the correct if/else statements made the code extremely complicated so I opted for restoring the file as it was at the time when we bumped the version.This also fixes the bug that we introduced in #13524.