hunspell: add Suggester#proceedPastRep to avoid losing relevant suggestions #13612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweiss
approved these changes
Jul 26, 2024
| } | ||
|
|
||
| /** | ||
| * Returns a copy of this suggester instance that doesn't stop after encountering acceptable words |
There was a problem hiding this comment.
It would be good to copy-paste this explanation to the PR's description, Peter. Explains what the patch is doing. I'll do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to get a copy of the suggester instance that doesn't stop after encountering acceptable words
(after applying REP rules). By default, Hunspell stops when it finds any, but this behavior may
not always be desirable, e.g., if we have "REP i ea", "tims" would be replaced only by "teams" and not "times", which
could also be meant.