Remove leftover search(Query, Collector) usages in TestTaxonomyFacetAssociations #13726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmiller
approved these changes
Sep 5, 2024
javanna
added a commit
that referenced
this pull request
Sep 6, 2024
|
It seems like I missed something, maybe that's why these methods were not migrated yet :) I got a failure with seed |
|
@javanna saw you addressed this by disabling concurrency in the test. I wonder if we should instead make the test more resilient to ordering and leverage the work in #13723 as a follow-up. WDYT? Update: Created #13738 to track this as a follow-up. We can always close it out if we don't think it's a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.