Deprecate FacetsCollector#search utility methods #13737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can now be replaced by the corresponding methods added to FacetsCollectorManager that accept a FacetsCollectorManager as last argument in place of a Collector Relates to apache#11041
javanna
changed the title
gsmiller
approved these changes
Sep 6, 2024
| @@ -54,4 +79,167 @@ public ReducedFacetsCollector(final Collection<FacetsCollector> facetsCollectors | |||
| facetsCollector -> matchingDocs.addAll(facetsCollector.getMatchingDocs())); | |||
| } | |||
| } | |||
|
|
|||
| /** Utility method, to search and also collect all hits into the provided {@link Collector}. */ | |||
There was a problem hiding this comment.
Shoot, I think I missed this in the earlier review but looks like we need a small javadoc cleanup here (need to mention FacetsCollectorManager instead of Collector right?). Same comment applies to all the new methods. Sorry for overlooking that.
I just updated these on main with a quick commit (dc47adb). Could you cherry-pick this down into the back-port as well (and feel free to tweak the language if you think of ways to improve on it). Thanks!
There was a problem hiding this comment.
good catch, I missed that. Will backport your commit!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can now be replaced by the corresponding methods added to FacetsCollectorManager that accept a FacetsCollectorManager as last argument in place of a Collector
This is the backport #13733 , minus the removal of the static methods which get instead deprecated in the 9x branch.
Relates to #11041