Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of calculations in FSTCompiler #13788

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Conversation

mrhbj
Copy link
Contributor

@mrhbj mrhbj commented Sep 14, 2024

Description

Copy link
Member

@mikemccand mikemccand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tiny optimization, it looks great.

Are you an AI or a real human ;) Let's try for a PR-based Turing Test!

Regardless of that outcome, this change is great -- I'll merge.

@mikemccand mikemccand merged commit 568d1f3 into apache:main Sep 14, 2024
3 checks passed
mikemccand pushed a commit that referenced this pull request Sep 14, 2024
* Simplify FST return

* Reduce number of calculations in FSTCompiler
@mikemccand mikemccand added this to the 9.12.0 milestone Sep 14, 2024
@mrhbj
Copy link
Contributor Author

mrhbj commented Sep 14, 2024

@mikemccand You are welcome. I am a ream human. no an AI. -_-

@mikemccand
Copy link
Member

@mikemccand You are welcome. I am a ream human. no an AI. -_-

Ahh thanks for the reply. Could you describe how you got involved / interested in open source development? How about specifically Apache Lucene?

@mrhbj
Copy link
Contributor Author

mrhbj commented Sep 19, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants