-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run filtered disjunctions with MaxScoreBulkScorer. #14014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running filtered disjunctions with a specialized bulk scorer seems to yield a good speedup. For what it's worth, I also tried to implement a MAXSCORE-based scorer to see if it had to do with the `BulkScorer` specialization or the algorithm, but it didn't help. To work properly, I had to add a rewrite rule to inline disjunctions in a MUST clause. As a next step, it would be interesting to see if we can further optimize this by loading the filter into a bitset and applying it like live docs.
Filtered stop words are slower but other queries are faster. |
jpountz
added a commit
that referenced
this pull request
Nov 27, 2024
Running filtered disjunctions with a specialized bulk scorer seems to yield a good speedup. For what it's worth, I also tried to implement a MAXSCORE-based scorer to see if it had to do with the `BulkScorer` specialization or the algorithm, but it didn't help. To work properly, I had to add a rewrite rule to inline disjunctions in a MUST clause. As a next step, it would be interesting to see if we can further optimize this by loading the filter into a bitset and applying it like live docs.
benchaplin
pushed a commit
to benchaplin/lucene
that referenced
this pull request
Dec 31, 2024
Running filtered disjunctions with a specialized bulk scorer seems to yield a good speedup. For what it's worth, I also tried to implement a MAXSCORE-based scorer to see if it had to do with the `BulkScorer` specialization or the algorithm, but it didn't help. To work properly, I had to add a rewrite rule to inline disjunctions in a MUST clause. As a next step, it would be interesting to see if we can further optimize this by loading the filter into a bitset and applying it like live docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running filtered disjunctions with a specialized bulk scorer seems to yield a good speedup. For what it's worth, I also tried to implement a MAXSCORE-based scorer to see if it had to do with the
BulkScorer
specialization or the algorithm, but it didn't help.To work properly, I had to add a rewrite rule to inline disjunctions in a MUST clause.
As a next step, it would be interesting to see if we can further optimize this by loading the filter into a bitset and applying it like live docs.