Reduce specialization in ForUtil and ForDeltaUtil.
#14048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These classes specialize all bits per value up to 24. But performance of high numbers of bits per value is not very important, because they are used by short postings lists, which are fast to iterate anyway. So this PR only specializes up to 16 bits per value. For instance, if a postings list uses blocks of 17 bits per value, it means that one can find gaps of 65,536 consecutive doc IDs that do not contain the term. Such rare terms do not drive query performance.
|
luceneutil doesn't notice any difference. |
rmuir
approved these changes
Dec 6, 2024
jpountz
added a commit
that referenced
this pull request
Dec 9, 2024
These classes specialize all bits per value up to 24. But performance of high numbers of bits per value is not very important, because they are used by short postings lists, which are fast to iterate anyway. So this PR only specializes up to 16 bits per value. For instance, if a postings list uses blocks of 17 bits per value, it means that one can find gaps of 65,536 consecutive doc IDs that do not contain the term. Such rare terms do not drive query performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes specialize all bits per value up to 24. But performance of high numbers of bits per value is not very important, because they are used by short postings lists, which are fast to iterate anyway. So this PR only specializes up to 16 bits per value.
For instance, if a postings list uses blocks of 17 bits per value, it means that one can find gaps of 65,536 consecutive doc IDs that do not contain the term. Such rare terms do not drive query performance.