-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Randomize KnnVector codec params in RandomCodec; addresses gh-14047 #14049
Conversation
oops a test failed; my bad for only beasting the ones in core ... I'll look at this one:
|
Another test fails now (this is going to be fun, it's hard to ferret all these things out proactively):
Looking at this test, I can't tell where these assertions came from: I think they might be too ambitious? @s1monw did you invent this? The entire class was created out of whole cloth, but I assume at least some of these tests were pre-existing? |
@msokolov I didn't invent this test. Yet, we never tested the current version obeying with it's own BWC expecations. Please make sure nothing randomizes anything in this test. BWC tests are not made for this. you need to supress anything that potentially randomizes stuff here.
maybe revert then? That's what it takes I guess? |
Thank Simon, that's good feedback about avoiding randomization for these tests. There's nothing to revert - this hasn't been committed, it's just github running tests that is failing. I do wonder though if we run the risk of a user with a customized Codec (just applying settings like graph bushiness and enabling quantization requires a custom Codec, so it would be typical) failing to be able to load an older index version for some reason, and we'd have no advance warning from the back-compat tests. Maybe that shouldn't be a concern, I'm not sure. In any case I will disable the randomization for these tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think this should have a "CHANGES" entry for the quantization bug fix. That bug will happen with uniform vector values which is common in testing infrastructure.
makes sense, I'll add a CHANGES entry and commit |
This adds the randomization to RandomCodec and addresses some test issues.