Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve use of generics in DisjunctionDISIApproximation construction #14095

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Improve use of generics in DisjunctionDISIApproximation construction #14095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lucene/core/src/java/org/apache/lucene/search/DisjunctionDISIApproximation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
public final class DisjunctionDISIApproximation extends DocIdSetIterator {

public static DisjunctionDISIApproximation of(
Collection<DisiWrapper> subIterators, long leadCost) {
Collection<? extends DisiWrapper> subIterators, long leadCost) {

return new DisjunctionDISIApproximation(subIterators, leadCost);
}
Expand All @@ -46,7 +46,8 @@ public static DisjunctionDISIApproximation of(
private DisiWrapper leadTop;
private int minOtherDoc;

public DisjunctionDISIApproximation(Collection<DisiWrapper> subIterators, long leadCost) {
public DisjunctionDISIApproximation(
Collection<? extends DisiWrapper> subIterators, long leadCost) {
// Using a heap to store disjunctive clauses is great for exhaustive evaluation, when a single
// clause needs to move through the heap on every iteration on average. However, when
// intersecting with a selective filter, it is possible that all clauses need advancing, which
Expand Down
Loading