Disable the query cache by default. #14187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query cache trades heap for faster queries. Given all the progress that has been made on making uncached queries faster (`IndexOrDocValuesQuery`, bitset encoding of blocks of postings, etc.), it's not obviously a good trade-off anymore. So I suggest that we make it an opt-in in Lucene 11.
|
I agree with the judgment, but maybe this just indicates we need to improve the cache! Still, until we can figure out how to do so, +1 to disable by default |
mikemccand
approved these changes
Feb 3, 2025
| @@ -30,6 +30,10 @@ Bug Fixes | |||
|
|
|||
| * GITHUB#14075: Remove duplicate and add missing entry on brazilian portuguese stopwords list. (Arthur Caccavo) | |||
|
|
|||
| Changes in Runtime Behavior | |||
| --------------------- | |||
| * GITHUB#14187: The query cache is now disabled by default. (Adrien Grand) | |||
There was a problem hiding this comment.
Maybe add a sentence about how to opt-in? Something like "call IndexSearcher.setQueryCache(new LRUQueryCache(1000, maxRamBytesUsed)) to get back to 10.x behavior" or so? Or maybe add these details to MIGRATE.md` instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query cache trades heap for faster queries. Given all the progress that has been made on making uncached queries faster (
IndexOrDocValuesQuery, bitset encoding of blocks of postings, etc.), it's not obviously a good trade-off anymore. So I suggest that we make it an opt-in in Lucene 11.