Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-10366: Override #readVInt and #readVLong for ByteBufferDataInput to avoid the abstraction confusion of #readByte. #592

Merged
merged 20 commits into from
Jan 16, 2024
Merged

LUCENE-10366: Override #readVInt and #readVLong for ByteBufferDataInput to avoid the abstraction confusion of #readByte. #592

Changes from 11 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f6b3afd
opt vint and vlong
gf2121 Jan 10, 2022
b792e94
spotless
gf2121 Jan 10, 2022
af6717e
ensure before valid
gf2121 Jan 11, 2022
23721de
add some note
gf2121 Jan 11, 2022
34f465c
spotless
gf2121 Jan 11, 2022
347fdb1
ensure for each call
gf2121 Jan 11, 2022
5fae0b2
use guard
gf2121 Jan 12, 2022
d917e56
loop bb
gf2121 Jan 14, 2022
480f383
just call super
gf2121 Jan 17, 2022
57be3d9
add note
gf2121 Jan 17, 2022
97d669b
spotless
gf2121 Jan 17, 2022
1955497
make readLongs final
gf2121 Jan 17, 2022
d30e08d
add CHANGES
gf2121 Jan 17, 2022
1f60b94
fix CHANGES
gf2121 Jan 17, 2022
c660283
fix note typo
gf2121 Jan 17, 2022
f3ca523
fix CHANGES
gf2121 Jan 17, 2022
e568907
Merge remote-tracking branch 'origin/main' into LUCENE-10366
gf2121 Jan 8, 2024
933bb29
move change entry
gf2121 Jan 8, 2024
03387bd
refactor MemorySegmentIndexInput
gf2121 Jan 9, 2024
5934cf4
refactor java21
gf2121 Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lucene/core/src/java/org/apache/lucene/store/ByteBufferIndexInput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,18 @@ public final int readInt() throws IOException {
}
}

@Override
public final int readVInt() throws IOException {
// this can make JVM less confusing (see LUCENE-10366)
return super.readVInt();
}

@Override
public final long readVLong() throws IOException {
// this can make JVM less confusing (see LUCENE-10366)
return super.readVLong();
}

@Override
public final long readLong() throws IOException {
try {
Expand Down