Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JVM error branch logic. #835

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fix JVM error branch logic. #835

merged 1 commit into from
Apr 25, 2022

Conversation

dweiss
Copy link
Contributor

@dweiss dweiss commented Apr 25, 2022

No description provided.

@dweiss dweiss mentioned this pull request Apr 25, 2022
Merged
@dweiss dweiss requested a review from uschindler April 25, 2022 12:19
uschindler
uschindler approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@uschindler uschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. This replicates what the UNIX shell script does, I think we forgot to update the windows wrapper scipt.

Thanks!

@dweiss
Copy link
Contributor Author

dweiss commented Apr 25, 2022

I think I made a logic mistake when I looked at what Robert pushed to the sh one, my fault.

@dweiss dweiss merged commit 2080caf into apache:main Apr 25, 2022
wjp719 added a commit to wjp719/lucene that referenced this pull request Apr 28, 2022
@wjp719
Merge branch 'main' into feature/skip_useless_attemps
3763818 
* main: (68 commits)
  LUCENE-10292: Suggest: Fix FreeTextSuggester so that getCount() returned results consistent with lookup() during concurrent build()
  LUCENE-10525 Improve WindowsFS emulation to catch invalid file names (apache#829)
  LUCENE-10508:  Use MIN_WIDE_EXTENT for all wide rectangles (apache#845)
  LUCENE-10470: [Tessellator] Fix some failing polygons due to collinear edges (apache#756)
  LUCENE-10508: Fix error for rectangles with an extent close to 180 degrees (apache#824)
  LUCENE-10529: Fix TestTaxonomyFacetAssociations NPE when randomly indexing no documents for dim
  fix path to jar file in demo documentation
  LUCENE-10499: reduce unnecessary copy data overhead when growing array size (apache#786)
  LUCENE-10535: upgrade com.palantir.consistent-versions to 2.10.0
  LUCENE-10533: SpellChecker.formGrams is missing bounds check (apache#836)
  Upgrade spotless and use runToFixMessage for 'gradlew tidy' hint. (apache#834)
  Fix JVM error branch logic. (apache#835)
  LUCENE-10493: factor out Viterbi algorithm and share it between kuromoji and nori (apache#805)
  LUCENE-8836: Speed up TermsEnum#lookupOrd on increasing sequences of ords. (apache#827)
  LUCENE-10528: use Xvfb in test to avoid messing up user's desktop (apache#828)
  LUCENE-10315: Speed up DocIdsWriter by ForUtil (apache#797)
  LUCENE-10517: Improve performance of SortedSetDV faceting by iterating on class types (apache#812)
  Add two facet tests (apache#826)
  fail clearly on too-new JDK (apache#819)
  improve spotless error to suggest running 'gradlew tidy' (apache#817)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uschindler uschindler uschindler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweiss @uschindler