Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup tests on additional platforms that .NET Standard supports #258

Closed
2 of 3 tasks
clambertus opened this issue Oct 11, 2019 · 2 comments
Closed
2 of 3 tasks

Setup tests on additional platforms that .NET Standard supports #258

clambertus opened this issue Oct 11, 2019 · 2 comments
Labels
up-for-grabs This issue is open to be worked on by anyone
Milestone

Comments

@clambertus
Copy link

clambertus commented Oct 11, 2019

We have recently setup an Azure DevOps YAML build configuration, which makes adding testing environments easier to our CI process. Adding tests to ensure support on macOS and Linux has been completed already, and (fortunately) the number of bugs that were found was fairly minimal (most of them were addressed in beta00006). However, there are other platforms .NET Standard supports that are commonly in use by Lucene.NET users which we should also setup our tests to run on.

Looking through the JIRA and GitHub issues, 4 platforms that have been mentioned are:

We should do a survey to find out what other platforms may be commonly in use and make the determination how important it is to test on them, and of course take into consideration whether the tests require a special setup that Azure Pipelines doesn't provide on any of the Microsoft-hosted agents.

JIRA link - [LUCENENET-633] created by nightowl888
@clambertus clambertus added Lucene.Net Test up-for-grabs This issue is open to be worked on by anyone labels May 5, 2020
@NightOwl888 NightOwl888 added this to the Lucene.NET 4.8.0-beta00009 milestone May 7, 2020
@NightOwl888 NightOwl888 self-assigned this May 7, 2020
@NightOwl888 NightOwl888 removed the up-for-grabs This issue is open to be worked on by anyone label May 8, 2020
@NightOwl888 NightOwl888 removed their assignment Jun 10, 2020
@NightOwl888 NightOwl888 modified the milestones: 4.8.0-beta00009, 4.8.0 Jun 10, 2020
NightOwl888 added a commit to NightOwl888/lucenenet that referenced this issue Sep 23, 2020
@NightOwl888 NightOwl888 added the up-for-grabs This issue is open to be worked on by anyone label Oct 16, 2020
@NightOwl888
Copy link
Contributor

MAUI will be a release candidate in April, 2022.

There are a set of xUnit tests noted here: dotnet/maui#2112 (comment). Looks like no specialized runner is required like was the case on Xamarin, so NUnit should work (in theory).

@paulirwin
Copy link
Contributor

Split apart testing on iOS and Android as #1031, given that is specific to those OSes and not MAUI itself. Closing this issue as otherwise effectively completed.

As far as target frameworks go, MAUI can use OS-specific TFMs like net8.0-ios, but this is a superset of the functionality in its base TFM (net8.0 for net8.0-ios). And given that Lucene.NET does not target any OS-specific TFMs, we should have no API compatibility issues there. More info: https://learn.microsoft.com/en-us/dotnet/standard/frameworks#net-5-os-specific-tfms

We also do not use any MAUI APIs, so that is not a concern with tests.

If it is feasible for us to use xharness to run tests on iOS and Android, and someone has the bandwidth to help contribute support for that, we can evaluate that for 4.8, but until then I think we can consider the Lucene.NET API surface that would run under MAUI generally tested for Windows, Linux, and macOS via our existing tests with the base TFMs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

3 participants