Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the visibility of 'EOS_FLAG_BIT' or make it 'const' or 'readonly' #679

Open
nikcio opened this issue Oct 15, 2022 · 1 comment
Open

Change the visibility of 'EOS_FLAG_BIT' or make it 'const' or 'readonly' #679

nikcio opened this issue Oct 15, 2022 · 1 comment
Labels
hacktoberfest-accepted is:enhancement New feature or request up-for-grabs This issue is open to be worked on by anyone
Milestone
4.8.0-beta00018

Comments

@nikcio
Copy link
Contributor

nikcio commented Oct 15, 2022 •
edited
Loading

Mentioned in #648

Specific issue: https://sonarcloud.io/project/issues?issues=AYRH0T92_qq9ReJdi431&open=AYRH0T92_qq9ReJdi431&id=apache_lucenenet

Make it const

Similar issues: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS2223&id=apache_lucenenet

For internal members, try declaring private. But a compile will be required to test whether that is valid (some fields may actually need to be internal).

Public members should generally be made const if it is valid to do so, or static readonly in other cases. Again, compiling is required to test whether that works.
@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone is:enhancement New feature or request hacktoberfest-accepted labels Oct 15, 2022
sachdevlaksh added a commit to sachdevlaksh/lucenenet that referenced this issue Oct 29, 2022
@sachdevlaksh
apache#679 Tried adding readonly and const to reduce visibility.
5a85bba
@sachdevlaksh sachdevlaksh mentioned this issue Oct 29, 2022
Closed
@paulirwin paulirwin added this to the 4.8.0-beta00018 milestone Oct 28, 2024
@paulirwin
Copy link
Contributor

Note: Related to #662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest-accepted is:enhancement New feature or request up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Milestone
4.8.0-beta00018
Development

Successfully merging a pull request may close this issue.

#679 Added sonar suggestions sachdevlaksh/lucenenet
3 participants
@NightOwl888 @paulirwin @nikcio