Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant jump statements #684

Closed
nikcio opened this issue Oct 15, 2022 · 0 comments
Closed

Redundant jump statements #684

nikcio opened this issue Oct 15, 2022 · 0 comments
Labels
good-first-issue Good for newcomers hacktoberfest-accepted is:enhancement New feature or request up-for-grabs This issue is open to be worked on by anyone

Comments

@nikcio
Copy link
Contributor

nikcio commented Oct 15, 2022 •
edited by NightOwl888
Loading

Mentioned in #648

Issues found: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS3626&id=nikcio_lucenenet

When there are return statements at the end of a method, we should comment them out in the source code and leave a // LUCENENET: comment after them why they were removed. A link to a related Code Analysis rule (preferred) or SonarCloud issue is fine.

For continue statements`, we should leave these as-is and add the necessary suppression to keep this issue from being detected by code analysis.
@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone good-first-issue Good for newcomers is:enhancement New feature or request hacktoberfest-accepted labels Oct 15, 2022
sachdevlaksh added a commit to sachdevlaksh/lucenenet that referenced this issue Oct 27, 2022
@sachdevlaksh
changes made for Redundant jump statements apache#684
6c8e624
@sachdevlaksh sachdevlaksh mentioned this issue Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers hacktoberfest-accepted is:enhancement New feature or request up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NightOwl888 @nikcio