-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test review A-D, #259 #1018
base: master
Are you sure you want to change the base?
Test review A-D, #259 #1018
Conversation
62389a0
to
0af80e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. The final PR of #259. Nice work!
There are a few changes to make to this before we can merge it. Plus, it came to my attention that there are some other things we need to review and fix before the release that we will need some issues opened for. Please see my comments inline.
Test review for core A-D tests
Fixes #259 (as the final PR for this issue)
Description
Add missing comments and attributes, match formatting, remove unnecessary code, etc.