Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website updates (from oct 2020) #391

Merged
merged 6 commits into from
Nov 18, 2020

Conversation

Shazwazza
Copy link
Contributor

Streamlines some of the build operations:

  • Uses powershell flags instead of 0/1
  • Updates docs on how to run the scripts including their params
  • re-enables our docfx plugins with custom MD parsers so the lucene version is automatically applied throughout the docs
  • Ensures the correct base path is used when building the docs for release so that linking works correctly

I have run this locally and the docs build so perhaps it fixes this? #380

@NightOwl888 NightOwl888 force-pushed the website-updates-oct-2020 branch from e75ccde to 93c3f9c Compare November 18, 2020 20:37
@NightOwl888
Copy link
Contributor

Thanks. This takes care of #380.

I added a fix for trimming the trailing slash if the user enters one and also a hack for setting the environment variable, since the plugin doesn't read it from the command line version.

There are still a lot of links that aren't resolving (example 1, example 2, example 3), but this is not a new issue.

@NightOwl888 NightOwl888 merged commit 0b448d9 into apache:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants