Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for lucene-cli appsettings.json required error + installation/run tests (See #453) #455

Merged

Conversation

NightOwl888
Copy link
Contributor

See #453.

This fixes the appsettings.json to make it optional and also adds a default appsettings.json to demonstrate the default settings that are available.

appsettings.json

{
  "egothor": { "stemmer": { "encoding": "UTF-8" } },
  "benchmark": { "work": { "dir": "work" } }
}

Note that egothor:stemmer:encoding can be set on the command line already, this is the default setting if no value is supplied. benchmark:work:directory can be supplied in a benchmark definition file and this is the default if it is not provided.

This serves as temporary documentation until #307 is completed.

Also, basic tests to install and run lucene-cli were added to ensure it can be installed and run without errors.

@NightOwl888 NightOwl888 self-assigned this Mar 27, 2021
@NightOwl888 NightOwl888 added this to the 4.8.0-beta00015 milestone Apr 5, 2021
@NightOwl888 NightOwl888 merged commit 2b9716f into apache:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant