BREAKING: Changed Cardinality() methods into Cardinality properties #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dinality. Types affected: FixedBitSet, Int64BitSet, OpenBitSet, PForDeltaDocIdSet, RandomAccessOrds, WAH8DocIdSet. Added obsolete extension methods for each type in the same namespace as each type, but do note this only works if the namespace is imported at the top of the file.
…occurrences of BitArray with BitSet. Removed FEATURE_BITARRAY_COPYTO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
Cardinality()across the API toCardinality(a property rather than a method). Affected types:Lucene.Net.Index.RandomAccessOrdsLucene.Net.Util.FixedBitSetLucene.Net.Util.Int64BitSetLucene.Net.Util.OpenBitSetLucene.Net.Util.PForDeltaDocIdSetLucene.Net.Util.WAH8DocIdSetExtension methods were also added in the same namespace for backward compatibility. These extension methods are hidden from Intellisense and marked obsolete. They will be removed in the first 4.8.0 release candidate.
This also factored out the
Lucene.Net.Support.BitArrayExtensionsclass (which was internal and had no tests) and removes all usage ofSystem.Collections.BitArrayin Lucene.NET which have been replaced withJ2N.Collections.BitSet.FEATURE_BITARRAY_COPYTOwas also removed.