SWEEP: Lucene.Net.Store: Fixed several Dispose() methods so they are safe to be called multiple times #854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #841. Part of #265.
This adds an atomic
CompareAndSetIsOpen(bool expect, bool update)
method toBaseDirectory
andBaseDirectoryWrapper
that can be used to ensure only a single call toDispose(bool)
will succeed. This is the same method signature asJ2N.Threading.Atomic.AtomicBoolean
and can be used the same way (without the extra heap allocation).This fixes
NRTCachingDirectory
(as well as all other directories) so they don't throw exceptions whenDispose()
is called multiple times.This of course means that
EnsureOpen()
will be active immediately whenDispose()
is first called, so be mindful of its usage when theDispose()
method needs to call local methods to clean up.