[MPOM-264] Set "maven.compiler.release" on JDK 9+ #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FTR: This is a simplified version of #48 which was declined back then. Nowadays the profile is even used within Maven Parent: https://issues.apache.org/jira/browse/MPOM-447 |
kwin
force-pushed
the
feature/configure-maven-compiler-release-on-JDK9+
branch
from
f0d7b0d to
413220e
Compare
kwin
commented
Jan 15, 2024
| <maven.compiler.source>${maven.compiler.target}</maven.compiler.source> | ||
| <maven.compiler.target>1.7</maven.compiler.target> | ||
| <maven.compiler.target>7</maven.compiler.target><!-- use version numbers without the "1." prefix (supported since javac 8) --> |
There was a problem hiding this comment.
should we enforce with https://maven.apache.org/enforcer/enforcer-rules/requireProperty.html that this property value does no longer start with "1."?
There was a problem hiding this comment.
I'm not sure if 7 is supported .... maybe it is time to switch it to 8
There was a problem hiding this comment.
yes it is: back to 5 if javac 8 is used, https://docs.oracle.com/javase/8/docs/technotes/tools/windows/javac.html#BHCDIFEE
There was a problem hiding this comment.
javac 17 still supports 7, only javac 21 only supports 8+.
michael-o
reviewed
Jan 15, 2024
pom.xml
Outdated
| @@ -525,6 +545,17 @@ under the License. | |||
| </build> | |||
| </profile> | |||
| <!-- END SNIPPET: release-profile --> | |||
| <profile> | |||
| <id>jdk9ornewer</id> | |||
There was a problem hiding this comment.
We also should update documentation.
https://maven.apache.org/pom/asf/
Rename profile id, document property "maven.release.property"
slawekjaranowski
approved these changes
Jan 16, 2024
michael-o
approved these changes
Jan 16, 2024
jbertram
added a commit
to jbertram/activemq-artemis
that referenced
this pull request
May 1, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build and removed any usage of the relevant classes from the code-base.
jbertram
added a commit
to jbertram/activemq-artemis
that referenced
this pull request
May 1, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build and removed any usage of the relevant classes from the code-base.
jbertram
added a commit
to jbertram/activemq-artemis
that referenced
this pull request
May 1, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build and removed any usage of the relevant classes from the code-base.
jbertram
added a commit
to jbertram/activemq-artemis
that referenced
this pull request
May 2, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build and removed any usage of the relevant classes from the code-base.
jbertram
added a commit
to jbertram/activemq-artemis
that referenced
this pull request
May 2, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build and removed any usage of the relevant classes from the code-base.
jbertram
added a commit
to jbertram/activemq-artemis
that referenced
this pull request
May 2, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build, switches to reflection, and adds `--add-opens` to the runtime JVM parameters.
jbertram
added a commit
to jbertram/activemq-artemis
that referenced
this pull request
May 2, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build, switches to reflection, and adds `--add-opens` to the runtime JVM parameters.
jbertram
added a commit
to jbertram/activemq-artemis
that referenced
this pull request
May 2, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build, switches to reflection, and adds `--add-opens` to the runtime JVM parameters.
jbertram
added a commit
to jbertram/activemq-artemis
that referenced
this pull request
May 2, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build, switches to reflection, and adds `--add-opens` to the runtime JVM parameters.
jbertram
added a commit
to jbertram/activemq-artemis
that referenced
this pull request
May 2, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build, switches to reflection, and adds `--add-opens` to the runtime JVM parameters.
jbertram
added a commit
to apache/activemq-artemis
that referenced
this pull request
May 6, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build, switches to reflection, and adds `--add-opens` to the runtime JVM parameters.
clebertsuconic
pushed a commit
to clebertsuconic/activemq-artemis
that referenced
this pull request
Jun 3, 2024
Due to apache/maven-apache-parent#188 the property `maven.compiler.release` is now being set which precludes exporting and using any internal Java classes. Therefore this commit removed references to `--add-exports` from the build, switches to reflection, and adds `--add-opens` to the runtime JVM parameters. (cherry picked from commit eac816f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.