test was asserting more than Java promises #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
approved these changes
Nov 16, 2020
|
Wait a minute, isn't this fixed with codehaus-plexus/plexus-archiver@e55f320 ? |
|
I don't think it is. That was an incorrect diagnosis of the test failure. The modification data equality failures were not simply the result of truncating milliseconds; and if they had been, would have been fixed by JDK 10+, which they weren't. The real issue is that modification dates aren't always precisely reproducible to the millisecond and can change asynchornously. It looks like a simple setter/getter for an object property, but it isn't. |
|
ok, just wanted to make sure change is done for the right reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consequently failing flakily. Last modified time is platform dependent and not a simple property of an object
@michael-o