Skip to content

Fix swallowed I/O exceptions by replacing PrintWriter with (OutputStreamWriter/BufferedWriter) #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarshMehta112 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −4
Open

Fix swallowed I/O exceptions by replacing PrintWriter with (OutputStreamWriter/BufferedWriter) #1281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/main/java/org/apache/maven/plugins/assembly/filter/AbstractLineAggregatingHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
package org.apache.maven.plugins.assembly.filter;

import java.io.BufferedReader;
import java.io.BufferedWriter;
import java.io.File;
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.OutputStreamWriter;
import java.io.PrintWriter;
import java.nio.file.Files;
import java.util.ArrayList;
import java.util.HashMap;
Expand Down Expand Up @@ -75,10 +75,11 @@ void addToArchive(final Archiver archiver) {
f = Files.createTempFile("assembly-" + fname, ".tmp").toFile();
f.deleteOnExit();

try (PrintWriter writer =
new PrintWriter(new OutputStreamWriter(Files.newOutputStream(f.toPath()), getEncoding()))) {
try (BufferedWriter writer =
new BufferedWriter(new OutputStreamWriter(Files.newOutputStream(f.toPath()), getEncoding()))) {
for (final String line : entry.getValue()) {
writer.println(line);
writer.write(line);
writer.newLine();
}
}
} catch (final IOException e) {
Expand Down