Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MASSEMBLY-1016] fix history #181

Merged
merged 2 commits into from
Feb 2, 2024
Merged

[MASSEMBLY-1016] fix history #181

merged 2 commits into from
Feb 2, 2024

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Feb 1, 2024

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should extends requirementsHistory to support since/from or version range ... 🤔

@hboutemy
Copy link
Member Author

hboutemy commented Feb 1, 2024

from experience filling that history, what is hard is that in general, there is an issue that tracks a system prerequisite update, then it's easy to write down the beginning of the range (since release x of the plugin, Java prerequisite is 8): what is important is to know the last previous plugin release that has the previous prerequisite (Java prerequisite 7 was ok until release "prev(x)").

but clarifying that the plugin release is "from x to y" for one set of prerequisites is a huge helper: we could propose a configuration that defines either version or from + to

we'll need to copy/paste that comment to a MPLUGIN issue...

@hboutemy
Copy link
Member Author

hboutemy commented Feb 1, 2024

while at it, I'll rephrase the "since" to "from", to avoid a different term that adds complexity...

@hboutemy hboutemy merged commit aeed884 into master Feb 2, 2024
55 checks passed
@hboutemy hboutemy deleted the MASSEMBLY-1016 branch February 2, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants