Upgrade parent POM to version 44 and fix the checkstyle violations#213
Upgrade parent POM to version 44 and fix the checkstyle violations#213olamy merged 4 commits intoapache:masterfrom
Conversation
|
There is #200 Did you build / test your PR? |
@slawekjaranowski there is a lot of checkstyle violations to refactor. I will push the next commit ASAP! |
I updated the maven-parent to version 44 in this PR, which seems to have introduced stricter Checkstyle rules that were not enforced previously. This caused a large number of Checkstyle violations to surface when running mvn clean install, making the build fail. 1. Method name formatting: Methods like These changes were necessary just to get a successful build with the updated parent version. cc @olamy |
src/main/java/org/apache/maven/buildcache/hash/HashFactory.java
Outdated
Show resolved
Hide resolved
|
in parent 43 rules was update:
in parent 44 - checstyle was enabled for test code: |
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.