Skip to content

Commit

Permalink
Revert fix and IT changes for MCHECKSTYLE-314
Browse files Browse the repository at this point in the history
The fix introduces another run of Checkstyle with default settings interfering with the one set in an execution.

git-svn-id: https://svn.apache.org/repos/asf/maven/plugins/trunk@1798404 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
michael-o committed Jun 11, 2017
1 parent c4a93f9 commit 17c66b8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 2 additions & 3 deletions src/it/MCHECKSTYLE-214-basedir-resource/verify.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@
def buildLog = new File( basedir, 'build.log' )

// LICENSE.txt has 2 errors, src/main/resources/README.txt has 1 error
// MCHECKSTYLE-314 added 2 errors from target/checkstyle-header.txt
assert buildLog.text.contains( "[INFO] There are 5 errors reported by Checkstyle" )
assert buildLog.text.contains( "[INFO] There are 3 errors reported by Checkstyle" )

def checkstyle = new XmlSlurper().parse( new File( basedir, "target/checkstyle-result.xml" ) )
assert 3 == checkstyle.file.size()
assert 2 == checkstyle.file.size()
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
import org.apache.maven.plugin.MojoFailureException;
import org.apache.maven.plugin.descriptor.PluginDescriptor;
import org.apache.maven.plugins.annotations.Component;
import org.apache.maven.plugins.annotations.Execute;
import org.apache.maven.plugins.annotations.LifecyclePhase;
import org.apache.maven.plugins.annotations.Mojo;
import org.apache.maven.plugins.annotations.Parameter;
Expand Down Expand Up @@ -74,7 +73,6 @@
*/
@Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST,
threadSafe = true )
@Execute( goal = "checkstyle" )
public class CheckstyleViolationCheckMojo
extends AbstractMojo
{
Expand Down

0 comments on commit 17c66b8

Please sign in to comment.